Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webb alexander-alderman-webb commented Nov 25, 2025

Description

Report discarded log size in bytes as part of client reports, based on the specification added in getsentry/sentry-docs@5819cdd.

The reported size is based on the log format submitted to the transport. The bytes representation used to calculate the size in bytes is returned by PayloadRef.get_bytes(). In all common code paths, the representation is a compact utf-8 encoding of the log.

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 25, 2025 09:47
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner November 25, 2025 09:47
@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft November 25, 2025 09:59
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 25, 2025 10:58
@alexander-alderman-webb alexander-alderman-webb marked this pull request as draft November 25, 2025 11:03
@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review November 25, 2025 11:08
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.04%. Comparing base (c720feb) to head (15ca53a).
⚠️ Report is 4 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5144   +/-   ##
=======================================
  Coverage   84.03%   84.04%           
=======================================
  Files         180      180           
  Lines       18223    18227    +4     
  Branches     3235     3236    +1     
=======================================
+ Hits        15314    15318    +4     
  Misses       1921     1921           
  Partials      988      988           
Files with missing lines Coverage Δ
sentry_sdk/_log_batcher.py 80.89% <100.00%> (+0.21%) ⬆️
sentry_sdk/client.py 83.71% <ø> (ø)
sentry_sdk/transport.py 84.49% <100.00%> (+0.12%) ⬆️

@alexander-alderman-webb alexander-alderman-webb merged commit ab0103e into master Nov 26, 2025
155 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/log-bytes branch November 26, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants