From dc02087b018266e6f80e9b3326824369f131d19a Mon Sep 17 00:00:00 2001 From: Eli Perkins Date: Thu, 30 Mar 2017 15:24:32 -0400 Subject: [PATCH] Remove superfluous calls to RCTConvert These calls to RCTConvert are inferred based on the types passed into the macro, according to the RN docs. http://facebook.github.io/react-native/releases/0.42/docs/native-modules-ios.html#argument-types --- ios/RNSentry.m | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ios/RNSentry.m b/ios/RNSentry.m index 5333e7cb8f..051b6b1a87 100644 --- a/ios/RNSentry.m +++ b/ios/RNSentry.m @@ -72,7 +72,7 @@ + (NSRegularExpression *)frameRegex { RCT_EXPORT_METHOD(startWithDsnString:(NSString * _Nonnull)dsnString) { - [SentryClient setShared:[[SentryClient alloc] initWithDsnString:[RCTConvert NSString:dsnString]]]; + [SentryClient setShared:[[SentryClient alloc] initWithDsnString:dsnString]]; [[SentryClient shared] startCrashHandler]; } @@ -111,7 +111,7 @@ + (NSRegularExpression *)frameRegex { RCT_EXPORT_METHOD(captureMessage:(NSString * _Nonnull)message level:(int)level) { - [[SentryClient shared] captureMessage:[RCTConvert NSString:message] level:level]; + [[SentryClient shared] captureMessage:message level:level]; } RCT_EXPORT_METHOD(setLogLevel:(int)level) @@ -121,12 +121,12 @@ + (NSRegularExpression *)frameRegex { RCT_EXPORT_METHOD(setExtras:(NSDictionary * _Nonnull)extras) { - [SentryClient shared].extra = [RCTConvert NSDictionary:extras]; + [SentryClient shared].extra = extras; } RCT_EXPORT_METHOD(setTags:(NSDictionary * _Nonnull)tags) { - [SentryClient shared].tags = [self sanitizeDictionary:[RCTConvert NSDictionary:tags]]; + [SentryClient shared].tags = [self sanitizeDictionary:tags]; } RCT_EXPORT_METHOD(setUser:(NSDictionary * _Nonnull)user)