-
-
Notifications
You must be signed in to change notification settings - Fork 355
Roll back development team changes done recently; set the correct development team for iOS app #5188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM 🚀
Thank you for the quick fix @alwx 🙇
|
Thank you for the fix! In the future, we should focus on a more permanent solution like |
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 818a608 | 495.84 ms | 498.08 ms | 2.25 ms |
| 8d89cc9+dirty | 537.83 ms | 536.02 ms | -1.81 ms |
| d916aa3 | 425.37 ms | 427.02 ms | 1.65 ms |
| 20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
| 1853710 | 555.47 ms | 556.59 ms | 1.12 ms |
| c1573b3 | 400.85 ms | 411.82 ms | 10.97 ms |
| 9f211e3 | 451.50 ms | 500.00 ms | 48.50 ms |
| e2fa43d | 451.68 ms | 462.42 ms | 10.74 ms |
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| 000da7a | 454.46 ms | 445.00 ms | -9.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 818a608 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 8d89cc9+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| d916aa3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 1853710 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| c1573b3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 9f211e3 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| e2fa43d | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 000da7a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
| ba75c7c+dirty | 1235.86 ms | 1226.45 ms | -9.41 ms |
| 000da7a+dirty | 1214.31 ms | 1221.91 ms | 7.61 ms |
| 23080e5+dirty | 1216.02 ms | 1224.94 ms | 8.91 ms |
| 8ece263+dirty | 1217.29 ms | 1213.35 ms | -3.94 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| d916aa3+dirty | 1221.02 ms | 1228.98 ms | 7.96 ms |
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
| c08359e+dirty | 1235.25 ms | 1233.96 ms | -1.29 ms |
| 64cd15c+dirty | 1216.31 ms | 1214.04 ms | -2.26 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| ba75c7c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 000da7a+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 23080e5+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 8ece263+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d916aa3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| c08359e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 64cd15c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
| ba75c7c+dirty | 1236.14 ms | 1240.69 ms | 4.55 ms |
| 000da7a+dirty | 1204.50 ms | 1218.94 ms | 14.44 ms |
| 23080e5+dirty | 1221.39 ms | 1222.08 ms | 0.70 ms |
| 8ece263+dirty | 1206.90 ms | 1211.45 ms | 4.55 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| d916aa3+dirty | 1211.02 ms | 1221.33 ms | 10.31 ms |
| 3e0a5f9+dirty | 1233.65 ms | 1239.10 ms | 5.45 ms |
| c08359e+dirty | 1200.59 ms | 1211.81 ms | 11.22 ms |
| 64cd15c+dirty | 1213.50 ms | 1223.54 ms | 10.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| ba75c7c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 000da7a+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 23080e5+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 8ece263+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d916aa3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3e0a5f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| c08359e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 64cd15c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
📢 Type of change
📜 Description
A follow up on this: #5057
Fixes the codesigning issue and returns back a few things from the iOS project configuration.
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog