Drop outdated clang-format from npm #5191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
Contributor
iOS (legacy) Performance metrics 🚀
|
Contributor
iOS (new) Performance metrics 🚀
|
Contributor
Android (new) Performance metrics 🚀
|
Collaborator
Author
|
Oh that's why! |
lucas-zimerman
changed the title
lucas-zimerman
commented
Sep 22, 2025
10 tasks
antonis
approved these changes
Sep 23, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🥇
Thank you for fixing this Lucas 🙇
antonis
pushed a commit
that referenced
this pull request
Sep 23, 2025
* enable ios logs: * logs * changelog * Drop outdated clang-format from npm (#5191) * enable logs on expo sample * repro' * patch clang-format and run it * return flags * return original sample code * more rollback * print clang version * remove deprecated package, add clang-format setup * try setup clang21 * other strategy to update clang/ more changes for version * gh action name change * Update .github/workflows/buildandtest.yml --------- Co-authored-by: Lucas Zimerman <lucaszimerman@Lucass-Mac-mini.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
For some reason, when running
yarn fixon macOS with ARM processor, it relies on an X86 wrapper/install of clang-format, throwing build errors if you don't have Rosetta installed.This PR will do the following changes:
Package
GH CI
clang 20 and other dependenciesso it matches a the output thatbrew installon macos produces.Clang Script
iOS Folder
yarn fixdue to new changes generated by newer clang-format.💡 Motivation and Context
Annoying errors where I can't use clang-format locally due to wrong CPU Arch. ALSO, clang-format was always producing different formating than CI clang-format, wasting developer time by manually fixing the CI format.
💚 How did you test it?
CI/Locally
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog.