From c878af48d7b05b59939893de3ca12a34dc962d02 Mon Sep 17 00:00:00 2001 From: Yuji Yaginuma Date: Thu, 11 Jan 2024 17:08:13 +0900 Subject: [PATCH 1/2] Add `bigdecimal` to the gemspec Since Ruby 3.3.0, RubyGems and Bundler warn if users do require the gems that will become the bundled gems in the future version of Ruby. Please see the "Standard library updates" section for the details. https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/ `sentry-ruby` uses one of those gems, `bigdecimal`. So now get the warning like the following. https://github.com/getsentry/sentry-ruby/actions/runs/7463068254/job/20306920751#step:6:89 This PR adds `bigdecimal` to the gemspec to fix the warning. --- CHANGELOG.md | 4 ++++ sentry-ruby/sentry-ruby.gemspec | 1 + 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ce728d145..48d554a80 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## Unreleased + +- Fix warning about default gems on Ruby 3.3.0 ([#2225](https://github.com/getsentry/sentry-ruby/pull/2225)) + ## 5.16.1 ### Bug Fixes diff --git a/sentry-ruby/sentry-ruby.gemspec b/sentry-ruby/sentry-ruby.gemspec index 154d7638c..77e9711ec 100644 --- a/sentry-ruby/sentry-ruby.gemspec +++ b/sentry-ruby/sentry-ruby.gemspec @@ -21,4 +21,5 @@ Gem::Specification.new do |spec| spec.require_paths = ["lib"] spec.add_dependency "concurrent-ruby", '~> 1.0', '>= 1.0.2' + spec.add_dependency "bigdecimal" end From 92d14cf1de125aec86757fbbfba9b572aacf02ee Mon Sep 17 00:00:00 2001 From: Yuji Yaginuma Date: Thu, 11 Jan 2024 17:17:53 +0900 Subject: [PATCH 2/2] Remove unsued require Base64 has unused since 46384cd5. --- sentry-ruby/lib/sentry/transport.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/sentry-ruby/lib/sentry/transport.rb b/sentry-ruby/lib/sentry/transport.rb index bab781ec1..1d4366a95 100644 --- a/sentry-ruby/lib/sentry/transport.rb +++ b/sentry-ruby/lib/sentry/transport.rb @@ -1,7 +1,6 @@ # frozen_string_literal: true require "json" -require "base64" require "sentry/envelope" module Sentry