Skip to content

Conversation

@solnic
Copy link
Collaborator

@solnic solnic commented Sep 19, 2025

Otherwise this command would crash with recent git.

@solnic solnic requested a review from sl0thentr0py September 19, 2025 14:31
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- [devcontainer] fix git command in run script ([#2710](https://github.com/getsentry/sentry-ruby/pull/2710))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 18f490b

git config --global safe.directory /workspace/sentry
git config --global safe.directory /workspace/sentry/vendor/gems/*
git config --global --replace-all safe.directory /workspace/sentry
git config --global --replace-all safe.directory /workspace/sentry/vendor/gems/*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Git Config Overwrites Safe Directories

The --replace-all flag on the second git config command causes it to overwrite the first safe.directory setting. This results in only /workspace/sentry/vendor/gems/* being configured as safe, while /workspace/sentry is unintentionally removed, which could lead to git operations failing.

Fix in Cursor Fix in Web

@codecov
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (4c02988) to head (18f490b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2710   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files         144      144           
  Lines        5652     5652           
=======================================
  Hits         5500     5500           
  Misses        152      152           
Components Coverage Δ
sentry-ruby 97.77% <ø> (ø)
sentry-rails 95.61% <ø> (ø)
sentry-sidekiq 96.57% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@solnic solnic merged commit fefc3b8 into master Sep 22, 2025
139 of 141 checks passed
@solnic solnic deleted the devcontainer-fix-git-command branch September 22, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants