fix(logging): prevent log errors from crashing main thread #2795
+69
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
2793-errors-shipping-logs-to-sentry-can-crash-main-app-thread
branch
from
a240d4b to
d6e13aa
Compare
Fixes #2793 When log events are shipped to Sentry (either synchronously when the buffer is full, or via the background thread), network errors could propagate to the main application thread and crash the application.
solnic
force-pushed
the
2793-errors-shipping-logs-to-sentry-can-crash-main-app-thread
branch
from
d6e13aa to
5ed486e
Compare
dingsdax
approved these changes
Nov 27, 2025
sl0thentr0py
approved these changes
Nov 27, 2025
solnic
deleted the
2793-errors-shipping-logs-to-sentry-can-crash-main-app-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2793
When log events are shipped to Sentry (either synchronously when the buffer is full, or via the background thread), network errors could propagate to the main application thread and crash the application.