Skip to content

Conversation

@Swatinem
Copy link
Contributor

No description provided.

@Swatinem Swatinem requested a review from a team June 18, 2020 10:10
Copy link
Contributor

@flub flub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't like perl? ;)

@Swatinem
Copy link
Contributor Author

You don't like perl? ;)

:-D Don’t really care either way. I copied this from here:

https://github.com/getsentry/symbolic/blob/67ceb271ad7d7fc659ad976293fca1e3cb72507f/scripts/bump-version#L12-L13

Its actually incredible that these scripts are completely unique across all sentry projects that I have looked at. And ideally craft would just do automatically depending on the type of project. One can still dream, right? ;-)

@Swatinem Swatinem merged commit 9951f53 into master Jun 18, 2020
@Swatinem Swatinem deleted the meta/publishing branch June 18, 2020 11:08
@jan-auer
Copy link
Member

jan-auer commented Jun 18, 2020

Please revert this. The bump-version script does not work on Linux. Either run with PERL, or do this instead:
https://github.com/getsentry/relay/blob/63d16b971ba0466aa7998bf1da2f269f4d4f60b0/scripts/bump-version.sh#L14-L16

Symbolic also needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants