chore: Update to use im 15.0.0
#254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(that fix was simple and not at all obvious) Closes getsentry#253
jrconlin
added a commit
to mozilla-services/syncstorage-rs
that referenced
this pull request
Sep 8, 2020
NOTE: This will disable cargo audit. Audit notes that sentry-core includes a vul'n dependency. Audit should be re-enabled once getsentry/sentry-rust#254 lands.
Swatinem
reviewed
Sep 8, 2020
sentry-core/src/scope/real.rs
Outdated
| event.extra.extend(self.extra.iter().cloned()); | ||
| event.tags.extend(self.tags.iter().cloned()); | ||
| event.contexts.extend(self.contexts.iter().cloned()); | ||
| event.breadcrumbs.extend(self.breadcrumbs.clone().into_iter()); |
Contributor
There was a problem hiding this comment.
Just run rustfmt on this:
- event.breadcrumbs.extend(self.breadcrumbs.clone().into_iter());
+ event
+ .breadcrumbs
+ .extend(self.breadcrumbs.clone().into_iter());
But can you explain why you need this? Is this an API change in im?
Contributor
Author
There was a problem hiding this comment.
Sure thing. (Sorry, I always forget to fmt)
Yeah, this looks to be a change required by im.
extend() changed from accepting a reference for a tuple to a tuple of references.
error[E0271]: type mismatch resolving `<im::hashmap::Iter<'_, std::string::String, sentry_types::protocol::v7::Context> as std::iter::Iterator>::Item == &_`
--> sentry-core/src/scope/real.rs:243:52
|
243 | event.contexts.extend(self.contexts.iter().cloned());
| ^^^^^^ expected tuple, found reference
|
= note: expected tuple `(&std::string::String, &sentry_types::protocol::v7::Context)`
found reference `&_`
jrconlin
added a commit
to mozilla-services/syncstorage-rs
that referenced
this pull request
Sep 9, 2020
NOTE: This will disable cargo audit. Audit notes that sentry-core includes a vul'n dependency. Audit should be re-enabled once getsentry/sentry-rust#254 lands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(that fix was simple and not at all obvious)
Closes #253