Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Turn of pprof default features #491

Merged
merged 1 commit into from
Aug 11, 2022
Merged

fix: Turn of pprof default features #491

merged 1 commit into from
Aug 11, 2022

Conversation

Swatinem
Copy link
Member

One of the pprof default features (cpp) pulls in symbolic-demangle,
which is used for demangling, but we don't use that feature at all since
we are only interested in raw instruction addrs which we symbolicate and
demangle server-side.

One of the pprof default features (`cpp`) pulls in `symbolic-demangle`,
which is used for demangling, but we don't use that feature at all since
we are only interested in raw instruction addrs which we symbolicate and
demangle server-side.
@Swatinem Swatinem requested a review from viglia August 11, 2022 08:52
@Swatinem Swatinem merged commit 0992040 into master Aug 11, 2022
@Swatinem Swatinem deleted the fix/pprof-default branch August 11, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants