Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add few verbs and punctuation #496

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Aug 22, 2022

Adding few verbs and punctuations makes the reading the description a bit clearer.

@olksdr olksdr requested a review from Swatinem August 22, 2022 10:26
@Swatinem Swatinem enabled auto-merge (squash) August 29, 2022 07:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #496 (8571260) into master (94c7bb5) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   79.40%   79.43%   +0.03%     
==========================================
  Files          76       76              
  Lines        9064     9064              
==========================================
+ Hits         7197     7200       +3     
+ Misses       1867     1864       -3     

@olksdr
Copy link
Contributor Author

olksdr commented Aug 31, 2022

Looks like some dependencies issues:

error: package `time v0.3.14` cannot be built because it requires rustc 1.59.0 or newer, while the currently active rustc version is 1.57.0
make: *** [check-no-default-features] Error 101
Error: Process completed with exit code 2.

but I do not see where this version is coming from. Locally Cargo.lock contains only following:

 "time 0.2.27",
 "time 0.3.13",

@Swatinem is there anything I can do here to help it to compile? 😄

@Swatinem
Copy link
Member

Swatinem commented Sep 1, 2022

We have to bump the MSRV: #498

@Swatinem Swatinem merged commit a9f81cb into master Sep 1, 2022
@Swatinem Swatinem deleted the fix/clarify-the-docs-in-sentry branch September 1, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants