Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Update to new standard Profile format #504

Merged
merged 9 commits into from
Oct 7, 2022

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Sep 21, 2022

This PR implements the new standard format for a Profile that will be used across all the different SDKs.

Relay related PR: #1462

@viglia viglia self-assigned this Sep 21, 2022
sentry-types/src/protocol/v7.rs Outdated Show resolved Hide resolved
sentry-types/Cargo.toml Show resolved Hide resolved
sentry-types/src/protocol/profile.rs Outdated Show resolved Hide resolved
sentry-types/src/protocol/profile.rs Outdated Show resolved Hide resolved
sentry-types/src/protocol/profile.rs Outdated Show resolved Hide resolved
sentry-types/src/protocol/profile.rs Show resolved Hide resolved
sentry-core/src/profiling.rs Show resolved Hide resolved
sentry-core/src/profiling.rs Outdated Show resolved Hide resolved
sentry-core/src/profiling.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

Merging #504 (c9e2921) into master (a433f63) will decrease coverage by 0.28%.
The diff coverage is 5.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
- Coverage   79.44%   79.16%   -0.29%     
==========================================
  Files          76       76              
  Lines        9059     9098      +39     
==========================================
+ Hits         7197     7202       +5     
- Misses       1862     1896      +34     

@kamilogorek kamilogorek mentioned this pull request Sep 22, 2022
sentry-core/src/profiling.rs Outdated Show resolved Hide resolved
sentry-core/src/profiling.rs Outdated Show resolved Hide resolved
@viglia viglia marked this pull request as ready for review October 7, 2022 14:00
@viglia viglia merged commit af1b255 into master Oct 7, 2022
@viglia viglia deleted the viglia/feat/update-to-standard-profile-format branch October 7, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants