Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable sentry via configuration #38

Closed
tristanbes opened this issue Jan 11, 2017 · 5 comments
Closed

Enable/Disable sentry via configuration #38

tristanbes opened this issue Jan 11, 2017 · 5 comments

Comments

@tristanbes
Copy link

@tristanbes tristanbes commented Jan 11, 2017

Hi,

Currently, there's no option to disable the bundle

So our local tests and our Travis builds are sending exception to Sentry that are useless

Why not provide a configuration option like http://symfony.com/doc/current/components/config/definition.html#optional-sections ?

@tristanbes tristanbes changed the title Disable the bundle Enable/Disable sentry via configuration Jan 11, 2017
@Addvilz

This comment has been minimized.

Copy link
Contributor

@Addvilz Addvilz commented Jan 11, 2017

You can do this by not setting the DSN option in these environments.

@tristanbes

This comment has been minimized.

Copy link
Author

@tristanbes tristanbes commented Jan 11, 2017

Thanks for your reply,

I think this should be mentionned in the README something like
"If the DSN entry is left empty, it will disable sentry"

@ryabenko-pro

This comment has been minimized.

Copy link

@ryabenko-pro ryabenko-pro commented Apr 17, 2017

With all the respect, adding an option and two lines of code will make it looks better.
Disabling plugin and removing DSN options are two different actions. This is not explicit and actually not correct, since no one will remove the string but comment it, which makes config file messy.
My car has neutral gear and I can use it when I want engine on, but car not moving. Highly recommended.

@Addvilz

This comment has been minimized.

Copy link
Contributor

@Addvilz Addvilz commented Apr 18, 2017

@ryabenko-pro hey, I never said it's a good way to do it :) But it's the one chosen by core devs apparently, and works in the same manner for all SDK's, so if not very sensible, it's at least consistent. I would prefer option to disable as well, however... See #21

@ryabenko-pro

This comment has been minimized.

Copy link

@ryabenko-pro ryabenko-pro commented Apr 18, 2017

@Addvilz, thanks! I'll address this message there then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.