First steps toward 3.0 and 2.0 SDK #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jan 28, 2019
HazAT
requested changes
Feb 22, 2019
| This command requires you to have Composer installed globally, as explained | ||
| in the [installation chapter](https://getcomposer.org/doc/00-intro.md) | ||
| of the Composer documentation. | ||
| > TODO: Flex recipe |
Contributor
Author
There was a problem hiding this comment.
Started WIP on symfony/recipes-contrib#621
| prefixes: ~ | ||
| release: ~ | ||
| ``` | ||
| TODO |
Member
There was a problem hiding this comment.
I would really just write basic docs here and move the majority to
https://github.com/getsentry/sentry-docs/tree/master/src/collections/_documentation/platforms/php symfony.md
HazAT
requested changes
Feb 22, 2019
Contributor
Author
|
@HazAT I've addressed your review; I would like to address all the other comments in separated PRs, since that would need the SDK package release. |
Closed
Co-Authored-By: Jean85 <alessandro.lai85@gmail.com>
Merged
HazAT
approved these changes
Feb 25, 2019
stayallive
approved these changes
Feb 25, 2019
Collaborator
stayallive
left a comment
stayallive
left a comment
There was a problem hiding this comment.
I'm going to assume @HazAT did a good job with this review 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the start of the work toward 3.0. A lot more options are to be mapped. I'll open other issues in the same milestone to track other missing steps.