Skip to content

Conversation

@Jean85
Copy link
Contributor

@Jean85 Jean85 commented Oct 2, 2020

No description provided.

@Jean85 Jean85 self-assigned this Oct 2, 2020
@ste93cry
Copy link
Contributor

ste93cry commented Oct 3, 2020

What's the benefit of this change? I like GitHub Actions even though I didn't use them yet, but I don't see how this could benefit us. Also, much more importantly, does the action you are going to use support Windows? I know we don't test the bundle on it and it doesn't matter so much compared to Linux builds, but it's a thing I would like to do since a long time

@Jean85
Copy link
Contributor Author

Jean85 commented Oct 3, 2020

I wanted to abandon Travis since the acquisition debacle (https://news.ycombinator.com/item?id=19218036); also their UX is getting less and less responsive.

GA supports Windows, yeah, and it's a lot more fast and responsive, probably due to the tight integration.

@ste93cry
Copy link
Contributor

ste93cry commented Oct 3, 2020

I wanted to abandon Travis since the acquisition debacle

I would not change a tool that still works great for political reasons, and honestly I see no benefit with this change apart from the fact that it's part of GitHub itself 😉 Said this, I don't intend to block this PR, go ahead if you think it's worth it

@Jean85 Jean85 marked this pull request as ready for review October 3, 2020 19:59
@Jean85
Copy link
Contributor Author

Jean85 commented Oct 3, 2020

Politics aside, it works better and faster: A full run in 1:36 with all checks in parallel: https://github.com/getsentry/sentry-symfony/actions/runs/285923001

@Jean85 Jean85 merged commit 894ee8f into 3.5.x Oct 3, 2020
@Jean85 Jean85 deleted the migrate-to-github-actions branch October 3, 2020 20:01
@stayallive
Copy link
Collaborator

stayallive commented Oct 4, 2020

@Jean85 I did notice the Zeus webhooks missing...

I would have first checked with @HazAT how important those are for the release cycle since I believe Craft does check in with Zeus.

If you did check that beforehand don't mind me but otherwise this might have to be reverted.

Edit: Also the required checks should be changed too if GHA can stay to force GHA to complete before a merge (probably merges will now be disallowed because Travis didn't run.

FWIW I would also like to use GHA if possible for everything but not sure if that's already possible with the processes in place @ Sentry 😄

@Jean85
Copy link
Contributor Author

Jean85 commented Oct 4, 2020

@stayallive my bad, I forgot about it. Shouldn't be possible to have the same hook from GA too? @HazAT ?

@HazAT
Copy link
Member

HazAT commented Oct 12, 2020

Yes, Zeus also works with GHA

https://github.com/getsentry/sentry-javascript/blob/master/.github/workflows/build.yml#L121

We just need to add the secret to the repo.
And btw. I think for PHP we don't need Zeus at all since there are no artifacts.

@stayallive
Copy link
Collaborator

Ah if we don't need Zeus we're good then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants