Skip to content

Add missing tests for the traceable cache adapters #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 21, 2021
Merged

Add missing tests for the traceable cache adapters #486

merged 3 commits into from
Apr 21, 2021

Conversation

@ste93cry
Copy link
Contributor

@ste93cry ste93cry commented Apr 20, 2021 •
edited
Loading

I just noticed that somehow I missed to make the unit tests for the traceable cache adapters, so here they are 😃

@ste93cry ste93cry added this to the 4.1 milestone Apr 20, 2021
@ste93cry ste93cry requested a review from Jean85 April 20, 2021 20:03
@ste93cry ste93cry force-pushed the add-missing-unit-tests-for-traceable-cache-adapters branch 2 times, most recently from 8f87d47 to e2ff7c5 Compare April 20, 2021 20:18
@Jean85
Copy link
Contributor

Jean85 commented Apr 21, 2021

CI is broken though... does #487 fix it?

@ste93cry ste93cry force-pushed the add-missing-unit-tests-for-traceable-cache-adapters branch from e2ff7c5 to cec88d8 Compare April 21, 2021 18:17
@ste93cry ste93cry force-pushed the add-missing-unit-tests-for-traceable-cache-adapters branch from cec88d8 to 7533031 Compare April 21, 2021 18:18
@ste93cry
Copy link
Contributor Author

ste93cry commented Apr 21, 2021

That PR helps fixing the build here by fixing the conditions needed to auto-enable the tracing instrumentation for the Cache component, which in turn allows me to safely require the symfony/cache-contracts package used in the unit tests without affecting whether the enablement status of the tracing feature. TL;DR: partially, yes

@ste93cry ste93cry force-pushed the add-missing-unit-tests-for-traceable-cache-adapters branch from 51c434f to 08940dd Compare April 21, 2021 18:52
@ste93cry ste93cry force-pushed the add-missing-unit-tests-for-traceable-cache-adapters branch from 08940dd to 9091447 Compare April 21, 2021 18:55
@ste93cry ste93cry merged commit 107f60c into master Apr 21, 2021
@ste93cry ste93cry deleted the add-missing-unit-tests-for-traceable-cache-adapters branch April 21, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Jean85 Jean85 Jean85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Improvement

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ste93cry @Jean85