From 1dff3b0956b1da222fcf09a1677b70afd1313942 Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Fri, 24 Sep 2021 22:07:05 +0200 Subject: [PATCH 1/3] Add a job for PHP 8.1 --- .github/workflows/tests.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 056cd8c5..0b415fa0 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -42,6 +42,9 @@ jobs: symfony_constraint: 3.4.* env: SYMFONY_DEPRECATIONS_HELPER: disabled + - description: '8.1' + php: '8.1' + composer_option: '--ignore-platform-req=php' - description: 'prefer lowest' php: '7.2' composer_option: '--prefer-lowest' From 5ea4855b34ad2647a9db1d5715f5412ba0cddea7 Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Thu, 7 Oct 2021 11:39:22 +0200 Subject: [PATCH 2/3] Try to avoid \Serializable deprecation --- tests/End2End/App/Controller/MainController.php | 2 +- tests/End2End/End2EndTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/End2End/App/Controller/MainController.php b/tests/End2End/App/Controller/MainController.php index bf0e5942..a8848838 100644 --- a/tests/End2End/App/Controller/MainController.php +++ b/tests/End2End/App/Controller/MainController.php @@ -41,7 +41,7 @@ public function exception(): Response public function fatal(): Response { - $foo = eval("return new class() implements \Serializable {};"); + $foo = eval("return new class() implements \JsonSerializable {};"); return new Response('This response should not happen: ' . json_encode($foo)); } diff --git a/tests/End2End/End2EndTest.php b/tests/End2End/End2EndTest.php index 37df19e1..b6211b9c 100644 --- a/tests/End2End/End2EndTest.php +++ b/tests/End2End/End2EndTest.php @@ -151,7 +151,7 @@ public function testGetFatal(): void $this->assertStringNotContainsString('not happen', $response->getContent() ?: ''); } catch (\RuntimeException $exception) { $this->assertStringContainsStringIgnoringCase('error', $exception->getMessage()); - $this->assertStringContainsStringIgnoringCase('contains 2 abstract methods', $exception->getMessage()); + $this->assertStringContainsStringIgnoringCase('contains 1 abstract method', $exception->getMessage()); $this->assertStringContainsStringIgnoringCase('MainController.php', $exception->getMessage()); $this->assertStringContainsStringIgnoringCase('eval()\'d code on line', $exception->getMessage()); } From 71f3680e805274e09a45aae3d31a75d92a86b03a Mon Sep 17 00:00:00 2001 From: Alessandro Lai Date: Thu, 7 Oct 2021 11:42:08 +0200 Subject: [PATCH 3/3] Try without ignore-platform-req --- .github/workflows/tests.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml index 0b415fa0..86d1fe72 100644 --- a/.github/workflows/tests.yaml +++ b/.github/workflows/tests.yaml @@ -18,6 +18,7 @@ jobs: fail-fast: false matrix: php: + - '8.1' - '8.0' - '7.4' - '7.3' @@ -42,9 +43,6 @@ jobs: symfony_constraint: 3.4.* env: SYMFONY_DEPRECATIONS_HELPER: disabled - - description: '8.1' - php: '8.1' - composer_option: '--ignore-platform-req=php' - description: 'prefer lowest' php: '7.2' composer_option: '--prefer-lowest'