Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Symfony support below 4.4 #643

Merged
merged 9 commits into from Jun 28, 2022
Merged

Drop Symfony support below 4.4 #643

merged 9 commits into from Jun 28, 2022

Conversation

Jean85
Copy link
Collaborator

@Jean85 Jean85 commented Jun 21, 2022

I'm opening this as a draft since it may require some discussion (or dropping some pieces of code no longer used).

3.4 is unsupported since last November: https://symfony.com/releases/3.4
Everything between that and 4.4 (since it's an LTS) is unsupported too.

Hence, dropping the support now makes sense. This PR is targeting develop, so it would land in the next minor (4.4 as of now).

@Jean85 Jean85 added this to the 4.4 milestone Jun 21, 2022
@Jean85 Jean85 self-assigned this Jun 21, 2022
@Jean85 Jean85 marked this pull request as ready for review June 21, 2022 14:03
@Jean85 Jean85 requested a review from ste93cry June 21, 2022 14:03
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RequestListenerTest::testHandleKernelRequestEvent() method is still using a data provider that was meant for Symfony < 4.4

tests/EventListener/RequestListenerTest.php Outdated Show resolved Hide resolved
src/DependencyInjection/SentryExtension.php Outdated Show resolved Hide resolved
@Jean85 Jean85 requested a review from ste93cry June 24, 2022 08:25
Copy link
Collaborator

@ste93cry ste93cry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still things to delete: in the SubRequestListenerTest class some of the data providers are still splitted per-Symfony version, and probably we can also remove the KernelEventForwardCompatibilityTrait trait. I suggest to look for occurences of the version_compare or Kernel::VERSION keywords

@Jean85
Copy link
Collaborator Author

Jean85 commented Jun 27, 2022

isMasterRequest got deprecated in 5.3, KernelEventForwardCompatibilityTrait is still needed: https://github.com/symfony/symfony/blob/a6af0ddb2bf79a8cec20478e4fd8b7bbe83bd1b6/src/Symfony/Component/HttpKernel/Event/KernelEvent.php#L84-L86.

I took care of the rest.

@Jean85 Jean85 requested a review from ste93cry June 27, 2022 10:24
@ste93cry ste93cry merged commit 6db5a35 into develop Jun 28, 2022
23 of 24 checks passed
@ste93cry ste93cry deleted the drop-symfony-3.4 branch June 28, 2022 17:49
alekitto pushed a commit to alekitto/sentry-symfony that referenced this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants