Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use constant for the SDK version #662

Merged
merged 5 commits into from Oct 11, 2022
Merged

Conversation

cleptric
Copy link
Member

Same as on PHP and Laravel. Relying on a constant has fewer side effects and is in line with how we do it on other SDKs.

Jean85
Jean85 approved these changes Oct 11, 2022
Copy link
Collaborator

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is PrettyVersions used anywhere in this codebase? Or could we drop it from the direct dependencies?

"jean85/pretty-package-versions": "^1.5 || ^2.0",

@cleptric
Copy link
Member Author

@Jean85 Still used here

->defaultValue(PrettyVersions::getRootPackageVersion()->getPrettyVersion())

@cleptric cleptric merged commit 70dcc0b into develop Oct 11, 2022
24 checks passed
@cleptric cleptric deleted the sdk-version-constant branch October 11, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants