Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Add proper HTTP client span descriptions #680

Merged
merged 3 commits into from Nov 24, 2022
Merged

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Nov 24, 2022

To make HTTP client tracing more useful, instead of setting HTTP GET, we now set scheme://authority/path as the span description.

The query and fragments parts are committed on purpose, see RFC 42

@cleptric cleptric merged commit 795376f into develop Nov 24, 2022
24 checks passed
@cleptric cleptric deleted the http-client-spans branch November 24, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants