From 2f7a6e83274707cecade767cb0c864d62646de12 Mon Sep 17 00:00:00 2001 From: Katie Byers Date: Thu, 9 May 2024 21:12:34 -0700 Subject: [PATCH] stop checking for missing groups when handling processed results --- .../endpoints/group_similar_issues_embeddings.py | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/src/sentry/api/endpoints/group_similar_issues_embeddings.py b/src/sentry/api/endpoints/group_similar_issues_embeddings.py index aa00efb555a982..9ec7d55aaa7020 100644 --- a/src/sentry/api/endpoints/group_similar_issues_embeddings.py +++ b/src/sentry/api/endpoints/group_similar_issues_embeddings.py @@ -131,21 +131,7 @@ def get_formatted_results( ) } - result = [] - for group_id in group_data: - try: - result.append((serialized_groups[group_id], group_data[group_id])) - except KeyError: - # KeyErrors may occur if seer API returns a deleted/merged group, which means it - # will be missing from `serialized_groups` - # - # TODO: This shouldn't be an issue for merged groups once we only use hashes (since - # merging leaves the hashes intact), but it will still be an error for deleted - # groups/hashes. - # - # TODO: Report back to seer that the hash has been deleted. - continue - return result + return [(serialized_groups[group_id], group_data[group_id]) for group_id in group_data] def get(self, request: Request, group) -> Response: if not features.has("projects:similarity-embeddings", group.project):