Skip to content

Commit 5087bb2

Browse files
fixed event section title for non thread
1 parent 03e1ede commit 5087bb2

File tree

3 files changed

+12
-10
lines changed

3 files changed

+12
-10
lines changed

static/app/components/events/eventDataSection.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ const StyledIconAnchor = styled(IconAnchor)`
123123
`;
124124

125125
const Permalink = styled('a')`
126+
width: 100%;
126127
:hover ${StyledIconAnchor} {
127128
display: block;
128129
color: ${p => p.theme.gray300};

static/app/components/events/interfaces/threadsV2/index.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {Fragment, useState} from 'react';
2+
import styled from '@emotion/styled';
23
import isNil from 'lodash/isNil';
34

45
import {isStacktraceNewestFirst} from 'app/components/events/interfaces/stacktrace';
@@ -178,7 +179,7 @@ function Threads({
178179
);
179180
}
180181

181-
return t('Stack Trace');
182+
return <Title>{t('Stack Trace')}</Title>;
182183
}
183184

184185
return (
@@ -205,3 +206,7 @@ function Threads({
205206
}
206207

207208
export default Threads;
209+
210+
const Title = styled('h3')`
211+
margin-bottom: 0;
212+
`;

static/app/components/events/traceEventDataSection/index.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,11 @@ function TraceEventDataSection({
9595
onChange={() => setState({...state, raw: !raw})}
9696
/>
9797
{raw ? (
98-
<Button
99-
size="small"
100-
disabled={!isNativePlatform(platform)}
101-
href={getDownloadHref()}
102-
>
103-
{t('Download')}
104-
</Button>
98+
isNativePlatform(platform) && (
99+
<Button size="small" href={getDownloadHref()}>
100+
{t('Download')}
101+
</Button>
102+
)
105103
) : (
106104
<Fragment>
107105
<SortOptions
@@ -144,8 +142,6 @@ const Header = styled('div')`
144142
grid-template-rows: repeat(3, 1fr);
145143
grid-gap: ${space(2)};
146144
flex: 1;
147-
align-items: center;
148-
justify-items: flex-end;
149145
z-index: 3;
150146
151147
@media (min-width: ${p => p.theme.breakpoints[0]}) {

0 commit comments

Comments
 (0)