From 7689af75dc6efc9a881cf392d5c0084e3ff50e41 Mon Sep 17 00:00:00 2001 From: Malachi Willey Date: Tue, 5 Mar 2024 10:02:51 -0800 Subject: [PATCH] feat(issue-priority): Rename issue stream tab inbox -> priority and remove unresolved tab (#66269) --- static/app/views/issueList/utils.spec.tsx | 8 +++++--- static/app/views/issueList/utils.tsx | 14 ++++++++------ 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/static/app/views/issueList/utils.spec.tsx b/static/app/views/issueList/utils.spec.tsx index e1cfd8e8bf40a..54578d700ec06 100644 --- a/static/app/views/issueList/utils.spec.tsx +++ b/static/app/views/issueList/utils.spec.tsx @@ -16,10 +16,12 @@ describe('getTabs', () => { ]); }); - it('should add inbox tab for issue-priority-ui feature', () => { - expect(getTabs(OrganizationFixture({features: ['issue-priority-ui']}))[0]).toEqual([ + it('should replace "unresolved" with "prioritized" for issue-priority-ui feature', () => { + const tabs = getTabs(OrganizationFixture({features: ['issue-priority-ui']})); + + expect(tabs[0]).toEqual([ 'is:unresolved issue.priority:[high, medium]', - expect.objectContaining({name: 'Inbox'}), + expect.objectContaining({name: 'Prioritized'}), ]); }); }); diff --git a/static/app/views/issueList/utils.tsx b/static/app/views/issueList/utils.tsx index 677c930c5be47..3ae084a8cfea8 100644 --- a/static/app/views/issueList/utils.tsx +++ b/static/app/views/issueList/utils.tsx @@ -5,7 +5,7 @@ import type {Organization} from 'sentry/types'; export enum Query { FOR_REVIEW = 'is:unresolved is:for_review assigned_or_suggested:[me, my_teams, none]', - INBOX = NEW_DEFAULT_QUERY, + PRIORITIZED = NEW_DEFAULT_QUERY, UNRESOLVED = 'is:unresolved', IGNORED = 'is:ignored', NEW = 'is:new', @@ -46,14 +46,16 @@ type OverviewTab = { * Get a list of currently active tabs */ export function getTabs(organization: Organization) { + const hasIssuePriority = organization.features.includes('issue-priority-ui'); + const tabs: Array<[string, OverviewTab]> = [ [ - Query.INBOX, + Query.PRIORITIZED, { - name: t('Inbox'), - analyticsName: 'inbox', + name: t('Prioritized'), + analyticsName: 'prioritized', count: true, - enabled: organization.features.includes('issue-priority-ui'), + enabled: hasIssuePriority, }, ], [ @@ -62,7 +64,7 @@ export function getTabs(organization: Organization) { name: t('Unresolved'), analyticsName: 'unresolved', count: true, - enabled: true, + enabled: !hasIssuePriority, }, ], [