ref(compliance): Allow failure on terms_accepted signal

getsentry · Feb 15, 2018 · f0fb315 · f0fb315
1 parent f425c63
commit f0fb315
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/sentry/api/endpoints/organization_index.py b/src/sentry/api/endpoints/organization_index.py
@@ -250,13 +250,6 @@ def post(self, request):
                         actor_id=request.user.id if request.user.is_authenticated() else None
                     )
 
-                    if result.get('agreeTerms'):
-                        terms_accepted.send(
-                            user=request.user,
-                            organization=org,
-                            sender=type(self),
-                        )
-
             except IntegrityError:
                 return Response(
                     {
@@ -265,5 +258,13 @@ def post(self, request):
                     status=409,
                 )
 
+            # failure on sending this signal is acceptable
+            if result.get('agreeTerms'):
+                terms_accepted.send_robust(
+                    user=request.user,
+                    organization=org,
+                    sender=type(self),
+                )
+
             return Response(serialize(org, request.user), status=201)
         return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)