From f0fb3155cca87f9196c1fd483e840aee3427995a Mon Sep 17 00:00:00 2001 From: David Cramer Date: Wed, 14 Feb 2018 15:37:27 -0800 Subject: [PATCH] ref(compliance): Allow failure on terms_accepted signal --- src/sentry/api/endpoints/organization_index.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/sentry/api/endpoints/organization_index.py b/src/sentry/api/endpoints/organization_index.py index 0893048f3820e4..b3ebc2f4c837e3 100644 --- a/src/sentry/api/endpoints/organization_index.py +++ b/src/sentry/api/endpoints/organization_index.py @@ -250,13 +250,6 @@ def post(self, request): actor_id=request.user.id if request.user.is_authenticated() else None ) - if result.get('agreeTerms'): - terms_accepted.send( - user=request.user, - organization=org, - sender=type(self), - ) - except IntegrityError: return Response( { @@ -265,5 +258,13 @@ def post(self, request): status=409, ) + # failure on sending this signal is acceptable + if result.get('agreeTerms'): + terms_accepted.send_robust( + user=request.user, + organization=org, + sender=type(self), + ) + return Response(serialize(org, request.user), status=201) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST)