Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Thread note added notification emails with alert emails #1067

Closed
dcramer opened this Issue Nov 21, 2013 · 6 comments

Comments

Projects
None yet
3 participants
Owner

dcramer commented Nov 21, 2013

Not entirely sure what headers we have to set, but should be trivial

Owner

mattrobenolt commented Nov 21, 2013

Literally no idea what this means.

This would be marvellous :)

Owner

dcramer commented Dec 16, 2013

tl;dr this is harder than I thought

there's some blurbs about In-Reply-To + Message-Id, as well as needing the subject line to match, etc

Maybe use the github issue emails as a reference - they will certainly have worked out the edge cases. They appear (by inspection) to add Message-ID to the original email, then all comments on the issue get a new Message-ID, and an In-Reply-To: & References: header to comments, which match the original issue Message-ID.

FWIW, in our internal apps we just set the subject to Re: <original subject> and it seems to work fine.

Owner

mattrobenolt commented Jan 13, 2014

This is fixed in master.

Thanks very much, the threading works great :)

At the risk of sounding ungrateful, it would be really nice if the text of the note came above the exception details. Many email clients show a content preview, and it's a bit of a shame that this is consumed by the duplicated exception details. If you look at github for example the comment is first, then the link to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment