Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cases where AdBlock/uBlock are blocking XHR requests #2049

Closed
mattrobenolt opened this issue Sep 29, 2015 · 3 comments
Closed

Handle cases where AdBlock/uBlock are blocking XHR requests #2049

mattrobenolt opened this issue Sep 29, 2015 · 3 comments
Milestone

Comments

@mattrobenolt
Copy link
Contributor

Since we use slugs for API calls, it's possible that a slug can trigger content blockers. In this case, we just error grossly with everything broken.

We should attempt to detect this and message to user.

@dcramer
Copy link
Member

dcramer commented Sep 29, 2015

I think a good first pass here is to run a simple timeout on the loader.

If it takes i.e. 15 seconds we show a message saying it's taking a long time to load with some basic help tips (i.e. maybe your adblocker is causing problems)

@dcramer
Copy link
Member

dcramer commented Oct 1, 2015

ae2a000 adds some basic detection that can be used elsewhere

@dcramer dcramer added this to the 8.0 Release milestone Oct 5, 2015
@mattrobenolt
Copy link
Contributor Author

I don't think there's anything else we can do here. Detection is in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants