Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organisational switch test has missing comma resulting in the 404 page being tested #30911

Closed
code-review-doctor opened this issue Jan 4, 2022 · 1 comment · Fixed by #30996
Assignees

Comments

@code-review-doctor
Copy link
Contributor

code-review-doctor commented Jan 4, 2022

The organisational switch test does not work as intended because there is implicit string concatenation on line 54

transition_urls = [
OrganizationSwitchTest.url_creator(page, self.organization.slug)
for page in ["issues", "releases" "discover", "user-feedback"]
]

There is a comma missing between "releases" and "discover" resulting in the two being implicitly concatenated together to form "releasesdiscover".

The impact is the test requesting "/releasesdiscover" which does not exist, and so instead of "/releases" and "/discover" being tested, instead the 404 page is tested.

Expected Result

Add the missing comma i.e.,
["issues", "releases", "discover", "user-feedback"]

Actual Result

NA

I will create a PR to fix this for you :)

@Kobby-Bawuah
Copy link

@markstory

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants