Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including context causes automatic OS/browser detection via User-Agent to fail #4553

Closed
nateberkopec opened this issue Nov 17, 2016 · 5 comments

Comments

@nateberkopec
Copy link
Contributor

getsentry/sentry-ruby#583

Providing contexts: :os or contexts: :runtime or even contexts: :server_os causes the autodetection plugin to not attempt to do anything. This is not ideal because, for example, on Rails application server we'd like to report the Ruby runtime version and server OS while keeping the auto browser detection.

In the meanwhile, we'll report this under extra context.

@nateberkopec
Copy link
Contributor Author

Ah yeah, this is it: https://github.com/getsentry/sentry/blob/master/src/sentry/plugins/sentry_useragents/models.py#L26

I'm not sure what behavior makes sense, but I really don't want to have to duplicate the User-Agent parsing logic Sentry already does.

@BYK
Copy link
Contributor

BYK commented Sep 30, 2020

Closing this issue due to staleness. Feel free to comment here if you think we should still work on this.

@BYK BYK closed this as completed Sep 30, 2020
@dentarg
Copy link

dentarg commented Sep 30, 2020

@BYK has this been solved?

@BYK
Copy link
Contributor

BYK commented Sep 30, 2020

@dentarg seems like it was with 2b0e63a#diff-d85a98fd4990c11990759887501fefbc

@dcramer do you remember anything about this?

@dcramer
Copy link
Member

dcramer commented Sep 30, 2020

I honestly don't remember

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants