feat(billing): add transaction retention to config as span #102095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| DataCategory.LOG_BYTE: "log", | ||
| DataCategory.TRANSACTION: "span", | ||
| DataCategory.SPAN: "span", | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: Duplicate Keys Cause Configuration Conflicts
The RETENTIONS_CONFIG_MAPPING maps DataCategory.TRANSACTION and DataCategory.SPAN to the same 'span' key. If both categories are present in retention data, dictionary comprehensions using this mapping will silently overwrite one value with the other. This results in unpredictable retention policies and potentially incorrect configuration sent to Relay.
Contributor
Author
There was a problem hiding this comment.
A customer can have either DataCategory.TRANSACTION or DataCategory.SPAN, but not both.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102095 +/- ##
=========================================
Coverage 80.97% 80.97%
=========================================
Files 8733 8733
Lines 388590 388701 +111
Branches 24654 24654
=========================================
+ Hits 314653 314751 +98
- Misses 73577 73590 +13
Partials 360 360 |
dashed
approved these changes
Oct 27, 2025
jjbayer
approved these changes
Oct 28, 2025
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For customers with
DataCategory.TRANSACTIONinstead ofDataCategory.SPANin their subscription plan, we want to provide the retention asspanin the project config.