chore(preprod): binary export insight #102459
Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| mh: <InlineCode>__mh_execute_header</InlineCode>, | ||
| dlsym: <InlineCode>dlsym</InlineCode>, | ||
| })} | ||
| </Text> |
There was a problem hiding this comment.
Bug: Bug
The tct call for adding symbols defines mh and dlsym in its interpolation object, but the template string only references [main]. This causes __mh_execute_header and dlsym to not be displayed, making the user instructions incomplete.
| <Flex direction="column" gap="md"> | ||
| <Heading as="h3" size="md"> | ||
| {t('Main Binary Export Metadata')} | ||
| </Heading> |
There was a problem hiding this comment.
IMO delete this heading
in the screenshot it just shows the title twice which seems redundant
| <Text> | ||
| {tct( | ||
| '[bold:How to fix]: Maintain a minimal allowlist so only required entry points stay exported.', | ||
| {bold: <strong />} |
There was a problem hiding this comment.
This modal UI seems inconsistent from the others
the other ones are
What it is
asdasd
How to fix
alsdkhaklsda
rather than
what it is: asdhashdlka
how to fix: asjkdaldjas
i think former is better
| </li> | ||
| <li> | ||
| <Text> | ||
| {tct('Add [main] on its own line', { |
There was a problem hiding this comment.
I feel like this line in the instructions is a bit too vague? maybe im dumb
| </Text> | ||
| </li> | ||
| </ol> | ||
| <Text>{t('Xcode now limits the export trie to just that allowlist')}</Text> |
There was a problem hiding this comment.
u-nit: i think this phrasing sounds a bit better as Xcode will now limit the export trie to just that allowlist
but not a blocker
| </Heading> | ||
| <Text> | ||
| {tct( | ||
| '[bold:What it is]: Binaries that act as entrypoints for your app, such as your main app binary or watchOS app binary, are not linked against by other binaries. This means the export trie information is unnecessary and can be removed.', |
There was a problem hiding this comment.
I think you can just delete the "what it is" text entirely from here
the title of the modal says what it is and the text right below it implicitly is the description of it
mtopo27
force-pushed
the
mtopo27/add-debug-symbol-insight
branch
from
c827625 to
373fba4
Compare
mtopo27
force-pushed
the
mtopo27/add-binary-export-insight-modal
branch
from
870bf4c to
f2f3c68
Compare
mtopo27
force-pushed
the
mtopo27/add-binary-export-insight-modal
branch
from
9dc1eca to
6c45b3b
Compare
mtopo27
force-pushed
the
mtopo27/add-binary-export-insight-modal
branch
from
2285348 to
94c3422
Compare
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.