Skip to content

chore(preprod): binary export insight #102459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 25, 2025
Merged

chore(preprod): binary export insight #102459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cfa431a
extra escape character?
mtopo27 Oct 31, 2025
8b732a3
comments
mtopo27 Nov 5, 2025
fe41d37
binary export insight
mtopo27 Oct 31, 2025
85a21cf
comments
mtopo27 Nov 5, 2025
94c3422
checkout debug symbol on main
mtopo27 Nov 6, 2025
0cea6eb
nico comments
mtopo27 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions static/app/views/preprod/buildDetails/main/insights/appSizeInsightsSidebarRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {formatBytesBase10} from 'sentry/utils/bytes/formatBytesBase10';
import {formatPercentage} from 'sentry/utils/number/formatPercentage';
import useOrganization from 'sentry/utils/useOrganization';
import {openAlternativeIconsInsightModal} from 'sentry/views/preprod/buildDetails/main/insights/alternativeIconsInsightInfoModal';
import {openMainBinaryExportedSymbolsModal} from 'sentry/views/preprod/buildDetails/main/insights/mainBinaryExportedSymbolsModal';
import {openMinifyLocalizedStringsModal} from 'sentry/views/preprod/buildDetails/main/insights/minifyLocalizedStringsModal';
import {openOptimizeImagesModal} from 'sentry/views/preprod/buildDetails/main/insights/optimizeImagesModal';
import {openStripDebugSymbolsModal} from 'sentry/views/preprod/buildDetails/main/insights/stripDebugSymbolsModal';
Expand Down Expand Up @@ -45,6 +46,7 @@ const INSIGHTS_WITH_MORE_INFO_MODAL = [
'image_optimization',
'webp_optimization',
'alternate_icons_optimization',
'main_binary_exported_symbols',
'localized_strings_minify',
'strip_binary',
];
Expand Down Expand Up @@ -91,6 +93,8 @@ export function AppSizeInsightsSidebarRow({
insight.key === 'webp_optimization'
) {
openOptimizeImagesModal(platform);
} else if (insight.key === 'main_binary_exported_symbols') {
openMainBinaryExportedSymbolsModal();
} else if (insight.key === 'localized_strings_minify') {
openMinifyLocalizedStringsModal();
} else if (insight.key === 'strip_binary') {
Expand Down
71 changes: 71 additions & 0 deletions static/app/views/preprod/buildDetails/main/insights/mainBinaryExportedSymbolsModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
import {openInsightInfoModal} from 'sentry/actionCreators/modal';
import {Flex} from 'sentry/components/core/layout';
import {Text} from 'sentry/components/core/text';
import {t, tct} from 'sentry/locale';
import {InlineCode} from 'sentry/views/preprod/buildDetails/main/insights/insightInfoModal';

function getMainBinaryExportedSymbolsContent() {
return (
<Flex direction="column" gap="2xl">
<Flex direction="column" gap="xl">
<Flex direction="column" gap="md">
<Text>
{t(
'Binaries that act as entrypoints for your app, such as your main app binary or watchOS app binary, are not linked against by other binaries. This means the export trie information is unnecessary and can be removed.'
)}
</Text>
<Text>
{t(
'You can maintain a minimal allowlist so only required entry points stay exported:'
)}
</Text>
</Flex>

<Flex direction="column" gap="md">
<ol>
<li>
<Text>
{tct('Create a text file in your project, for example [path]', {
path: <InlineCode>Config/ExportedSymbols.txt</InlineCode>,
})}
</Text>
</li>
<li>
<Text>
{tct('Add [main] on its own line', {
Copy link
Contributor

@NicoHinderling NicoHinderling Oct 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this line in the instructions is a bit too vague? maybe im dumb

main: <InlineCode>_main</InlineCode>,
mh: <InlineCode>__mh_execute_header</InlineCode>,
dlsym: <InlineCode>dlsym</InlineCode>,
})}
</Text>
Copy link
Contributor

@cursor cursor bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Bug

The tct call for adding symbols defines mh and dlsym in its interpolation object, but the template string only references [main]. This causes __mh_execute_header and dlsym to not be displayed, making the user instructions incomplete.

Fix in Cursor Fix in Web

</li>
<li>
<Text>
{t('If you rely on other dynamic lookups, list those symbols too')}
</Text>
</li>
<li>
<Text>
{tct('In Xcode, set [setting] to the new file’s path', {
setting: (
<strong>
{t('Build Settings → Linking → Exported Symbols File')}
</strong>
),
})}
</Text>
</li>
</ol>
<Text>{t('Xcode will now limit the export trie to just that allowlist.')}</Text>
</Flex>
</Flex>
</Flex>
);
}

export function openMainBinaryExportedSymbolsModal() {
openInsightInfoModal({
title: t('Main binary export metadata'),
children: getMainBinaryExportedSymbolsContent(),
});
}
Loading