From 35fe4a50066d71c8e8aafec621c6e203fe09eff9 Mon Sep 17 00:00:00 2001 From: srest2021 Date: Wed, 5 Nov 2025 14:32:46 -0800 Subject: [PATCH] make separate index --- migrations_lockfile.txt | 2 +- .../1004_add_semver_with_build_code_index.py | 53 +++++++++++++++++++ src/sentry/models/release.py | 17 ++++++ 3 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 src/sentry/migrations/1004_add_semver_with_build_code_index.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 58b305d3859c21..0c2c3a17273a38 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -31,7 +31,7 @@ releases: 0003_real_delete_dual_written_commit_tables replays: 0006_add_bulk_delete_job -sentry: 1003_group_history_prev_history_safe_removal +sentry: 1004_add_semver_with_build_code_index social_auth: 0003_social_auth_json_field diff --git a/src/sentry/migrations/1004_add_semver_with_build_code_index.py b/src/sentry/migrations/1004_add_semver_with_build_code_index.py new file mode 100644 index 00000000000000..37d999f0b5408c --- /dev/null +++ b/src/sentry/migrations/1004_add_semver_with_build_code_index.py @@ -0,0 +1,53 @@ +# Generated by Django 5.2.1 on 2025-11-05 22:32 + +from django.db import migrations, models + +from sentry.new_migrations.migrations import CheckedMigration + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("sentry", "1003_group_history_prev_history_safe_removal"), + ] + + operations = [ + migrations.AddIndex( + model_name="release", + index=models.Index( + models.F("organization"), + models.OrderBy(models.F("major"), descending=True), + models.OrderBy(models.F("minor"), descending=True), + models.OrderBy(models.F("patch"), descending=True), + models.OrderBy(models.F("revision"), descending=True), + models.OrderBy( + models.Case(models.When(prerelease="", then=1), default=0), descending=True + ), + models.OrderBy(models.F("prerelease"), descending=True), + models.OrderBy( + models.Case( + models.When(build_code__isnull=False, build_number__isnull=True, then=2), + models.When(build_number__isnull=False, then=1), + default=0, + ), + descending=True, + ), + models.OrderBy(models.F("build_number"), descending=True), + models.OrderBy(models.F("build_code"), descending=True), + name="sentry_release_semver_new_idx", + ), + ), + ] diff --git a/src/sentry/models/release.py b/src/sentry/models/release.py index 23deab547d01f2..c4fe87d98995fe 100644 --- a/src/sentry/models/release.py +++ b/src/sentry/models/release.py @@ -291,6 +291,23 @@ class Meta: F("prerelease").desc(), name="sentry_release_semver_idx", ), + models.Index( + "organization", + F("major").desc(), + F("minor").desc(), + F("patch").desc(), + F("revision").desc(), + Case(When(prerelease="", then=1), default=0).desc(), + F("prerelease").desc(), + Case( + When(build_number__isnull=True, build_code__isnull=False, then=2), + When(build_number__isnull=False, then=1), + default=0, + ).desc(), + F("build_number").desc(), + F("build_code").desc(), + name="sentry_release_semver_new_idx", + ), models.Index(fields=("organization", "build_code")), models.Index(fields=("organization", "build_number")), models.Index(fields=("organization", "date_added")),