fix(orgstats): Update the query to be able to filter by user's project #102762

priscilawebdev · 2025-11-05T05:55:14Z

closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

linear · 2025-11-05T05:55:17Z

TET-1370 Check filters on Stats & Usage page for Project dropdown

codecov · 2025-11-05T06:13:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #102762   +/-   ##
========================================
  Coverage   80.92%    80.92%           
========================================
  Files        8931      8931           
  Lines      391099    391096    -3     
  Branches    24863     24862    -1     
========================================
- Hits       316485    316483    -2     
+ Misses      74246     74245    -1     
  Partials      368       368

…rameter-filter-logic

priscilawebdev · 2025-11-05T07:53:24Z

tests/snuba/api/endpoints/test_organization_stats_v2.py

+                {"by": {}, "series": {"sum(quantity)": [0, 8]}, "totals": {"sum(quantity)": 8}}
            ],
            "start": isoformat_z(floor_to_utc_day(self._now) - timedelta(days=1)),
            "end": isoformat_z(floor_to_utc_day(self._now) + timedelta(days=1)),
        }

        response = self.do_request(
            {
                "project": [-1],
                "statsPeriod": "1d",
                "interval": "6h",
                "field": ["sum(quantity)"],
                "category": ["error"],
            },
            status_code=200,
        )

        assert result_sorted(response.data) == {
            "intervals": [
                isoformat_z((self._now - timedelta(days=1)).replace(hour=12, minute=0, second=0)),
                isoformat_z((self._now - timedelta(days=1)).replace(hour=18, minute=0, second=0)),
                isoformat_z(self._now.replace(hour=0, minute=0, second=0)),
                isoformat_z(self._now.replace(hour=6, minute=0, second=0)),
                isoformat_z(self._now.replace(hour=12, minute=0, second=0)),
            ],
            "groups": [
                {
                    "by": {},
-                    "series": {"sum(quantity)": [0, 0, 0, 6, 0]},
-                    "totals": {"sum(quantity)": 6},
+                    "series": {"sum(quantity)": [0, 0, 0, 8, 0]},
+                    "totals": {"sum(quantity)": 8},
                }
            ],
            "start": isoformat_z(
                self._now.replace(hour=12, minute=0, second=0) - timedelta(days=1)
            ),
            "end": isoformat_z(self._now.replace(hour=18, minute=0, second=0)),
        }

    @freeze_time(_now)
    def test_user_org_total_all_accessible(self) -> None:
        response = self.do_request(
            {
                "project": [-1],
                "statsPeriod": "1d",
                "interval": "1d",
                "field": ["sum(quantity)"],
                "category": ["error", "transaction"],
            },
            user=self.user2,
            status_code=200,
        )

        assert result_sorted(response.data) == {
            "start": isoformat_z(floor_to_utc_day(self._now) - timedelta(days=1)),
            "end": isoformat_z(floor_to_utc_day(self._now) + timedelta(days=1)),
            "intervals": [
                isoformat_z(floor_to_utc_day(self._now) - timedelta(days=1)),
                isoformat_z(floor_to_utc_day(self._now)),
            ],
            "groups": [
-                {"by": {}, "series": {"sum(quantity)": [0, 7]}, "totals": {"sum(quantity)": 7}}
+                {"by": {}, "series": {"sum(quantity)": [0, 9]}, "totals": {"sum(quantity)": 9}}


this is because of the new added outcome

sentry/tests/snuba/api/endpoints/test_organization_stats_v2.py

Line 93 in 0690954

self.store_outcomes(

priscilawebdev · 2025-11-05T07:53:36Z

tests/snuba/api/endpoints/test_organization_stats_v2.py

+                {
+                    "by": {"project": self.project5.id},
+                    "totals": {"sum(quantity)": 2},
+                },


same here

sentry/tests/snuba/api/endpoints/test_organization_stats_v2.py

Line 93 in 0690954

self.store_outcomes(

constantinius · 2025-11-05T08:07:54Z

src/sentry/api/endpoints/organization_stats_v2.py

            [
-                not project_ids or project_ids == ALL_ACCESS_PROJECTS,
+                # ALL_ACCESS_PROJECTS ({-1}) signals that stats should aggregate across
+                # all projects rather than filtering to specific project IDs


I would really replace this with an if-statement with the two conditions anded together.

constantinius · 2025-11-05T08:10:43Z

src/sentry/api/endpoints/organization_stats_v2.py

        return all(
            [
-                not project_ids or project_ids == ALL_ACCESS_PROJECTS,
+                # ALL_ACCESS_PROJECTS ({-1}) signals that stats should aggregate across
+                # all projects rather than filtering to specific project IDs
+                project_ids == ALL_ACCESS_PROJECTS,
                "project" not in request.GET.get("groupBy", []),
            ]
        )


Suggested change

return all(

[

not project_ids or project_ids == ALL_ACCESS_PROJECTS,

# ALL_ACCESS_PROJECTS ({-1}) signals that stats should aggregate across

# all projects rather than filtering to specific project IDs

project_ids == ALL_ACCESS_PROJECTS,

"project" not in request.GET.get("groupBy", []),

]

)

return (

# ALL_ACCESS_PROJECTS ({-1}) signals that stats should aggregate across

# all projects rather than filtering to specific project IDs

project_ids == ALL_ACCESS_PROJECTS

and "project" not in request.GET.get("groupBy", [])

)

github-actions · 2025-11-05T10:41:53Z

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

sentry · 2025-11-05T11:28:53Z

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

‼️ [**AssertionError: assert {'by': {'pro...antity)': 6...** in test

getsentry-bot · 2025-11-05T12:38:50Z

PR reverted: 574cda2

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

#102762) closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

#102762) closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

#102762) closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

fix(orgstats): Update the query to be able to filter by user's project

bcfe50b

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 5, 2025

vercel bot deployed to Preview November 5, 2025 05:56 View deployment

priscilawebdev added 2 commits November 5, 2025 08:51

fix tests

0690954

Merge branch 'master' into priscila/fix/orgstats/fix-query-project-pa…

f0664c3

…rameter-filter-logic

priscilawebdev commented Nov 5, 2025

View reviewed changes

priscilawebdev requested a review from a team November 5, 2025 07:54

vercel bot deployed to Preview November 5, 2025 07:57 View deployment

constantinius reviewed Nov 5, 2025

View reviewed changes

frontend fix

ed146f3

github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 5, 2025

suggestion

19e1850

vercel bot deployed to Preview November 5, 2025 10:46 View deployment

constantinius approved these changes Nov 5, 2025

View reviewed changes

priscilawebdev marked this pull request as ready for review November 5, 2025 11:11

priscilawebdev requested review from a team as code owners November 5, 2025 11:11

priscilawebdev merged commit 6982620 into master Nov 5, 2025
69 checks passed

priscilawebdev deleted the priscila/fix/orgstats/fix-query-project-parameter-filter-logic branch November 5, 2025 11:14

priscilawebdev added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Nov 5, 2025

getsentry-bot added a commit that referenced this pull request Nov 5, 2025

Revert "fix(orgstats): Update the query to be able to filter by user'…

574cda2

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

priscilawebdev added a commit that referenced this pull request Nov 6, 2025

fix(orgstats): Update the query to be able to filter by user's project (

adac080

#102762) closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

priscilawebdev added a commit that referenced this pull request Nov 6, 2025

Revert "fix(orgstats): Update the query to be able to filter by user'…

2299b06

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025

fix(orgstats): Update the query to be able to filter by user's project (

af6c5ef

#102762) closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025

Revert "fix(orgstats): Update the query to be able to filter by user'…

027d302

…s project (#102762)" This reverts commit 6982620. Co-authored-by: priscilawebdev <29228205+priscilawebdev@users.noreply.github.com>

andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025

fix(orgstats): Update the query to be able to filter by user's project (

8e4099c

#102762) closes https://linear.app/getsentry/issue/TET-1370/check-filters-on-stats-and-usage-page-for-project-dropdown

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(orgstats): Update the query to be able to filter by user's project #102762

fix(orgstats): Update the query to be able to filter by user's project #102762

Uh oh!

priscilawebdev commented Nov 5, 2025

Uh oh!

linear bot commented Nov 5, 2025

Uh oh!

codecov bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

priscilawebdev Nov 5, 2025

Uh oh!

priscilawebdev Nov 5, 2025

Uh oh!

constantinius Nov 5, 2025

Uh oh!

constantinius Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Uh oh!

sentry bot commented Nov 5, 2025

Uh oh!

getsentry-bot commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix(orgstats): Update the query to be able to filter by user's project #102762

fix(orgstats): Update the query to be able to filter by user's project #102762

Uh oh!

Conversation

priscilawebdev commented Nov 5, 2025

Uh oh!

linear bot commented Nov 5, 2025

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

priscilawebdev Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

priscilawebdev Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

constantinius Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

constantinius Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Uh oh!

sentry bot commented Nov 5, 2025

Issues attributed to commits in this pull request

Uh oh!

getsentry-bot commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 5, 2025 •

edited

Loading