ref(tracemetrics): Add more analytics events for metrics #102824
Conversation
This adds two primary events for when the users land on the page. Closes LOGS-473
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const { | ||
| data: {hasExceededPerformanceUsageLimit}, | ||
| isLoading: isLoadingSubscriptionDetails, | ||
| } = usePerformanceSubscriptionDetails({traceItemDataset: 'default'}); |
There was a problem hiding this comment.
Bug: Use Metrics Dataset for Trace Usage Checks
The useMetricsAnalytics function incorrectly passes traceItemDataset: 'default' to usePerformanceSubscriptionDetails. Since this function is tracking metrics analytics and the PR adds support for the 'metrics' dataset (including the traceMetrics category in the subscription type), it should use traceItemDataset: 'metrics' instead to check the correct usage limit (traceMetrics.usageExceeded) rather than defaulting to transactions/spans limits.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| metricQueries: Array<{queryParams: ReadableQueryParams}>; | ||
| }) { | ||
| const organization = useOrganization(); | ||
| const {selection} = usePageFilters(); |
There was a problem hiding this comment.
Bug: useMetricsAnalytics uses traceItemDataset: 'default' instead of 'metrics', leading to incorrect usage limit checks.
Severity: MEDIUM | Confidence: 0.90
🔍 Detailed Analysis
The useMetricsAnalytics hook incorrectly invokes usePerformanceSubscriptionDetails with traceItemDataset: 'default'. This configuration causes the system to evaluate usage limits against transactions.usageExceeded or spans.usageExceeded instead of the intended traceMetrics.usageExceeded. As a result, the metrics.explorer.metadata analytics event will report an inaccurate value for has_exceeded_performance_usage_limit concerning metrics usage.
💡 Suggested Fix
Modify the call to usePerformanceSubscriptionDetails within useMetricsAnalytics to use traceItemDataset: 'metrics' instead of traceItemDataset: 'default' to ensure accurate usage limit evaluation.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/explore/hooks/useAnalytics.tsx#L878
Potential issue: The `useMetricsAnalytics` hook incorrectly invokes
`usePerformanceSubscriptionDetails` with `traceItemDataset: 'default'`. This
configuration causes the system to evaluate usage limits against
`transactions.usageExceeded` or `spans.usageExceeded` instead of the intended
`traceMetrics.usageExceeded`. As a result, the `metrics.explorer.metadata` analytics
event will report an inaccurate value for `has_exceeded_performance_usage_limit`
concerning metrics usage.
Did we get this right? 👍 / 👎 to inform future reviews.
| const [interval] = useChartInterval(); | ||
| const topEvents = useTopEvents(); | ||
|
|
||
| useMetricsPanelAnalytics({ |
There was a problem hiding this comment.
This is going to fire once per panel and again when the query changes for the panel. Is this the intended behaviour?
There was a problem hiding this comment.
This hook is very overloaded lol
This adds two primary events for when the users land on the page. Closes LOGS-473
This adds two primary events for when the users land on the page. Closes LOGS-473
This adds two primary events for when the users land on the page.
Closes LOGS-473