Skip to content

Conversation

@TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Nov 6, 2025

and the script because it created an invalid comment

and the script because it created an invalid comment
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@TkDodo TkDodo marked this pull request as ready for review November 6, 2025 10:15
@TkDodo TkDodo requested a review from a team as a code owner November 6, 2025 10:15
@TkDodo
Copy link
Collaborator Author

TkDodo commented Nov 6, 2025

@ryan953 seems like we’re not running the script to auto-update in CI ?

@TkDodo TkDodo requested a review from ryan953 November 6, 2025 10:15
@ryan953
Copy link
Member

ryan953 commented Nov 7, 2025

hrm, here's the CI run for a PR that added a new route: https://github.com/getsentry/sentry/actions/runs/19086287053/job/54527125120

not a lot of helpful logs there. but the script call seems to have passed, and the "Apply any file changes" step was skipped. digging in more.

Edit:
Looks like i did a copy+paste. The other step getsentry/action-github-app-token also didn't run, and that's because if: env.SECRET_ACCESS == 'true' is false which both of these steps are checking...
So the fix is to do the step getsentry/action-github-app-token unconditionally, and then check for it's success: steps.token.outcome == 'success'. This is how the other two spots inside this yaml file do it.

Edit 2:
the fix #102935

Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeps things in sync. :shipit:

@TkDodo TkDodo merged commit 015670e into master Nov 7, 2025
68 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/update-known-urls branch November 7, 2025 07:46
Ahmed-Labs pushed a commit that referenced this pull request Nov 10, 2025
and the script because it created an invalid comment
Ahmed-Labs pushed a commit that referenced this pull request Nov 10, 2025
and the script because it created an invalid comment
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
and the script because it created an invalid comment
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
and the script because it created an invalid comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants