ref(replay): filter out events before replay start for log messages

[michellewzhang]

related to: #102897

backend PR for filtering out events that occur before the replay start time, so we don't have to generate log messages for those. we filter out these events on the frontend as well -- they aren't shown as breadcrumbs.

also fix some timestamp inconsistencies in tests

[cursor]

Bug: Prematurely Emitting Pre-Start Error Events

Remaining error events are yielded without checking if they occurred before replay_start_ms. After processing all segment events, the code yields all remaining errors regardless of their timestamps, allowing error messages from before the replay started to appear in the logs.

src/sentry/replays/usecases/summarize.py#L310-L320

sentry/src/sentry/replays/usecases/summarize.py

Lines 310 to 320 in 9a5ea32

	# Yield any remaining error messages
	while error_idx < len(error_events):
	error = error_events[error_idx]
	if error["category"] == "error":
	yield generate_error_log_message(error)
	elif error["category"] == "feedback":
	yield generate_feedback_log_message(error)
	error_idx += 1

 

---

[cursor]

Bug: Feedback breadcrumb timestamp in seconds causes filtering error

The feedback breadcrumb timestamp in the test is in seconds instead of milliseconds. The timestamp field should be float((now - timedelta(minutes=3)).timestamp() * 1000) to match the expected millisecond format for segment events, causing this feedback to be incorrectly filtered out as occurring before the replay start.

tests/sentry/replays/usecases/test_summarize.py#L1404-L1405

sentry/tests/sentry/replays/usecases/test_summarize.py

Lines 1404 to 1405 in 3488fa5

	self.store_replay(dt=now - timedelta(minutes=10), segment_id=0, trace_ids=[trace_id])

 

---

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff              @@
##           master   #102931       +/-   ##
============================================
+ Coverage   65.88%    80.70%   +14.81%     
============================================
  Files        9226      9027      -199     
  Lines      394039    393500      -539     
  Branches    25103     24958      -145     
============================================
+ Hits       259610    317559    +57949     
+ Misses     130896     75544    -55352     
+ Partials     3533       397     -3136