Skip to content

ci: Fix Github job to run python3 -m tools.api_urls_to_typescript #102935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

ci: Fix Github job to run python3 -m tools.api_urls_to_typescript #102935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,7 @@ jobs:
runs-on: ubuntu-24.04
timeout-minutes: 10
steps:
- # get a non-default github token so that any changes are verified by CI
if: env.SECRET_ACCESS == 'true'
uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
- uses: getsentry/action-github-app-token@d4b5da6c5e37703f8c3b3e43abb5705b46e159cc # v3.0.0
Copy link
Contributor

@cursor cursor bot Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Token Step Fails Job; Continue-On-Error Missing

The action-github-app-token step lacks continue-on-error: true, causing the entire job to fail if token generation fails. This prevents python3 -m tools.api_urls_to_typescript from running, unlike similar jobs (requirements, typing) which use continue-on-error: true to ensure the main task executes regardless of token availability.

Fix in Cursor Fix in Web

id: token
with:
app_id: ${{ vars.SENTRY_INTERNAL_APP_ID }}
Expand All @@ -265,7 +263,6 @@ jobs:

- name: Setup sentry env
uses: ./.github/actions/setup-sentry
id: setup
with:
mode: backend-ci

Expand All @@ -274,8 +271,7 @@ jobs:
python3 -m tools.api_urls_to_typescript

- name: Apply any file changes
# note: this runs "always" or else it's skipped when pre-commit fails
if: env.SECRET_ACCESS == 'true' && startsWith(github.ref, 'refs/pull') && always()
if: github.ref != 'refs/heads/master' && always()
uses: getsentry/action-github-commit@31f6706ca1a7b9ad6d22c1b07bf3a92eabb05632 # v2.0.0
with:
github-token: ${{ steps.token.outputs.token }}
Expand Down
Loading