Skip to content

Conversation

@TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Nov 7, 2025

this isn't needed as all tests pass without it, but it breaks the msw poc because the service worker intercepts that "request" too

this isn't needed as all tests pass without it, but it breaks the msw poc because the service worker intercepts that "request" too
@TkDodo TkDodo requested a review from JonasBa November 7, 2025 21:00
@TkDodo TkDodo marked this pull request as ready for review November 7, 2025 21:00
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 7, 2025
@TkDodo TkDodo changed the title ref(tests): remove XMLHttpRequest ref(tests): remove XMLHttpRequest in mock API Nov 7, 2025
Copy link
Member

@JonasBa JonasBa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahaha, called it 😂

@TkDodo TkDodo merged commit bc84efe into master Nov 8, 2025
49 checks passed
@TkDodo TkDodo deleted the tkdodo/ref/xmlhttprequest-in-tests branch November 8, 2025 07:36
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
this isn't needed as all tests pass without it, but it breaks the msw
poc because the service worker intercepts that "request" too
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
this isn't needed as all tests pass without it, but it breaks the msw
poc because the service worker intercepts that "request" too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants