dev(agents): Guidance on options and slow DB queries #103059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes included: * Do not suggest a default value when using `options.get()` * When filtering on columns, check that there's a composite index
armenzg
commented
Nov 10, 2025
| batch_size = options.get("deletions.group-hash-metadata.batch-size") | ||
|
|
||
| # WRONG: Redundant default value | ||
| batch_size = options.get("deletions.group-hash-metadata.batch-size", 1000) |
Member
Author
There was a problem hiding this comment.
I keep getting suggested to do it this way when coding.
| 4. Add indexes for queries on 1M+ row tables | ||
| 5. Use `db_index=True` or `db_index_together` | ||
|
|
||
| #### Composite Index Strategy: Match Your Query Patterns |
Member
Author
There was a problem hiding this comment.
This is one of the most repeating issues I have seen in the deletions code yet I introduced the same problem my self! (using id and seer_matched_hash_id in the same query):
#102960 (comment)
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Changes included: * Do not suggest a default value when using `options.get()` * When filtering on columns, check that there's a composite index
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Changes included: * Do not suggest a default value when using `options.get()` * When filtering on columns, check that there's a composite index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included:
options.get()