From 2dfc0dd864758e96ffab9f9ca20ddcf07ed7fc29 Mon Sep 17 00:00:00 2001 From: Priscila Oliveira Date: Mon, 10 Nov 2025 15:26:22 +0100 Subject: [PATCH] ref(project-settings): Remove not used name field --- static/app/components/forms/jsonForm.spec.tsx | 2 +- .../app/data/forms/projectGeneralSettings.tsx | 14 +++++------- .../settings/projectGeneralSettings/index.tsx | 22 +------------------ 3 files changed, 7 insertions(+), 31 deletions(-) diff --git a/static/app/components/forms/jsonForm.spec.tsx b/static/app/components/forms/jsonForm.spec.tsx index 5550f93ce35317..5cc6d28e5de57f 100644 --- a/static/app/components/forms/jsonForm.spec.tsx +++ b/static/app/components/forms/jsonForm.spec.tsx @@ -170,7 +170,7 @@ describe('JsonForm', () => { }); describe('fields prop', () => { - const jsonFormFields = [fields.name, fields.platform] as FieldObject[]; + const jsonFormFields = [fields.slug, fields.platform] as FieldObject[]; it('default', () => { render(); diff --git a/static/app/data/forms/projectGeneralSettings.tsx b/static/app/data/forms/projectGeneralSettings.tsx index 0b266af71765e0..b0ed55c0671119 100644 --- a/static/app/data/forms/projectGeneralSettings.tsx +++ b/static/app/data/forms/projectGeneralSettings.tsx @@ -50,28 +50,24 @@ const StyledPlatformIcon = styled(PlatformIcon)` `; export const fields = { - name: { - name: 'name', + slug: { + name: 'slug', type: 'string', required: true, label: t('Slug'), - placeholder: t('my-awesome-project'), help: t('A unique ID used to identify this project'), - transformInput: slugify, - getData: (data: {name?: string}) => { + transformInput: slugify as (str: string) => string, + getData: (data: {slug?: string}) => { return { - name: data.name, - slug: data.name, + slug: data.slug, }; }, - saveOnBlur: false, saveMessageAlertType: 'warning', saveMessage: t( "Changing a project's slug can break your build scripts! Please proceed carefully." ), }, - platform: { name: 'platform', type: 'select', diff --git a/static/app/views/settings/projectGeneralSettings/index.tsx b/static/app/views/settings/projectGeneralSettings/index.tsx index 69d6210d3533d3..07b6aa63887124 100644 --- a/static/app/views/settings/projectGeneralSettings/index.tsx +++ b/static/app/views/settings/projectGeneralSettings/index.tsx @@ -37,7 +37,6 @@ import {handleXhrErrorResponse} from 'sentry/utils/handleXhrErrorResponse'; import type {ApiQueryKey} from 'sentry/utils/queryClient'; import {setApiQueryData, useQueryClient} from 'sentry/utils/queryClient'; import recreateRoute from 'sentry/utils/recreateRoute'; -import slugify from 'sentry/utils/slugify'; import useApi from 'sentry/utils/useApi'; import {useLocation} from 'sentry/utils/useLocation'; import {useNavigate} from 'sentry/utils/useNavigate'; @@ -312,25 +311,6 @@ export function ProjectGeneralSettings({project, onChangeSlug}: Props) { help: t('The unique identifier for this project. It cannot be modified.'), }; - const slugField: FieldObject = { - name: 'slug', - type: 'string', - required: true, - label: t('Slug'), - help: t('A unique ID used to identify this project'), - transformInput: slugify as (str: string) => string, - getData: (data: {slug?: string}) => { - return { - slug: data.slug, - }; - }, - saveOnBlur: false, - saveMessageAlertType: 'warning', - saveMessage: t( - "Changing a project's slug can break your build scripts! Please proceed carefully." - ), - }; - // Create filtered platform field without mutating the shared fields object const platformField = { ...fields.platform, @@ -357,7 +337,7 @@ export function ProjectGeneralSettings({project, onChangeSlug}: Props) {