From b644bfd7b0e40b15b06bb0c5698a37d181d109f9 Mon Sep 17 00:00:00 2001
From: Evan Purkhiser <evanpurkhiser@gmail.com>
Date: Mon, 10 Nov 2025 17:56:21 -0500
Subject: [PATCH] ref(crons): Remove unneeded self.tasks in detector index
 tests

---
 .../test_organization_detector_index.py       | 59 +++++++++----------
 1 file changed, 27 insertions(+), 32 deletions(-)

diff --git a/tests/sentry/monitors/endpoints/test_organization_detector_index.py b/tests/sentry/monitors/endpoints/test_organization_detector_index.py
index 5b40c47404586b..3a782fe0750eec 100644
--- a/tests/sentry/monitors/endpoints/test_organization_detector_index.py
+++ b/tests/sentry/monitors/endpoints/test_organization_detector_index.py
@@ -116,12 +116,11 @@ def _get_detector_post_data(self, **overrides):
 
     def test_create_monitor_incident_detector_validates_correctly(self):
         data = self._get_detector_post_data()
-        with self.tasks():
-            response = self.get_success_response(
-                self.organization.slug,
-                **data,
-                status_code=201,
-            )
+        response = self.get_success_response(
+            self.organization.slug,
+            **data,
+            status_code=201,
+        )
 
         assert response.data["name"] == "Test Monitor Detector"
         assert response.data["type"] == MonitorIncidentType.slug
@@ -195,12 +194,11 @@ def test_create_monitor_with_optional_fields(self):
                 }
             ],
         )
-        with self.tasks():
-            self.get_success_response(
-                self.organization.slug,
-                **data,
-                status_code=201,
-            )
+        self.get_success_response(
+            self.organization.slug,
+            **data,
+            status_code=201,
+        )
 
         monitor = Monitor.objects.get(
             organization_id=self.organization.id, slug="full-config-monitor"
@@ -228,13 +226,12 @@ def test_update_monitor_incident_detector(self):
             "name": "Updated Detector",
             "owner": new_user.get_actor_identifier(),
         }
-        with self.tasks():
-            response = self.get_success_response(
-                self.organization.slug,
-                self.detector.id,
-                **data,
-                status_code=200,
-            )
+        response = self.get_success_response(
+            self.organization.slug,
+            self.detector.id,
+            **data,
+            status_code=200,
+        )
 
         assert response.data["name"] == "Updated Detector"
         assert response.data["owner"] == {
@@ -269,13 +266,12 @@ def test_update_monitor_config_through_detector(self):
                 }
             ],
         }
-        with self.tasks():
-            self.get_success_response(
-                self.organization.slug,
-                self.detector.id,
-                **data,
-                status_code=200,
-            )
+        self.get_success_response(
+            self.organization.slug,
+            self.detector.id,
+            **data,
+            status_code=200,
+        )
 
         self.detector.refresh_from_db()
         assert self.detector.name == "Updated Detector With Monitor Config"
@@ -295,12 +291,11 @@ class OrganizationDetectorDeleteTest(BaseDetectorTestCase):
     def test_delete_monitor_incident_detector(self):
         detector_id = self.detector.id
         monitor_id = self.monitor.id
-        with self.tasks():
-            self.get_success_response(
-                self.organization.slug,
-                detector_id,
-                status_code=204,
-            )
+        self.get_success_response(
+            self.organization.slug,
+            detector_id,
+            status_code=204,
+        )
         self.detector.refresh_from_db()
         assert self.detector.status == ObjectStatus.PENDING_DELETION
         assert Monitor.objects.filter(id=monitor_id).exists()