fix(issue-details): Do not show since first seen when config is disabled #103176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| children: | ||
| period === defaultStatsPeriod && | ||
| !defaultStatsPeriod.isMaxRetention | ||
| !defaultStatsPeriod.isMaxRetention && |
Contributor
There was a problem hiding this comment.
Bug: Dropdown choice incorrectly clears configuration.
The onChange handler clears statsPeriod when relative === defaultStatsPeriod?.statsPeriod without checking shouldShowSinceFirstSeenOption. When this config is false, defaultStatsPeriod.statsPeriod is always "14d", so selecting "14 days" from the dropdown incorrectly clears the URL parameter instead of setting it. The special clearing logic should only apply when shouldShowSinceFirstSeenOption is true.
scttcper
approved these changes
Nov 11, 2025
malwilley
deleted the
malwilley/fix/do-not-show-since-first-seen-when-config-is-disabled
branch
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a config option show
sinceFirstSeen, which is used to determine the default stats period, but we don't remove the option from the time range selector. This fixes that.You can see this issue on replay issues (and the new metric issues)
Before (14d interval, but shows "since first seen")
After