Skip to content

fix(issue-details): Do not show since first seen when config is disabled #103176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

fix(issue-details): Do not show since first seen when config is disabled #103176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions static/app/views/issueDetails/streamline/eventDetailsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export function EventDetailsHeader({group, event, project}: EventDetailsHeaderPr
const hasSetStatsPeriod =
location.query.statsPeriod || location.query.start || location.query.end;
const defaultStatsPeriod = useGroupDefaultStatsPeriod(group, project);
const shouldShowSinceFirstSeenOption = issueTypeConfig.defaultTimePeriod.sinceFirstSeen;
const period = hasSetStatsPeriod
? getPeriod({
start: location.query.start as string,
Expand Down Expand Up @@ -132,7 +133,8 @@ export function EventDetailsHeader({group, event, project}: EventDetailsHeaderPr
return {
...props.arbitraryOptions,
// Always display arbitrary issue open period
...(defaultStatsPeriod?.statsPeriod
...(defaultStatsPeriod?.statsPeriod &&
shouldShowSinceFirstSeenOption
? {
[defaultStatsPeriod.statsPeriod]: t(
'%s (since first seen)',
Expand Down Expand Up @@ -162,7 +164,8 @@ export function EventDetailsHeader({group, event, project}: EventDetailsHeaderPr
triggerProps={{
children:
period === defaultStatsPeriod &&
!defaultStatsPeriod.isMaxRetention
!defaultStatsPeriod.isMaxRetention &&
Copy link
Contributor

@cursor cursor bot Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dropdown choice incorrectly clears configuration.

The onChange handler clears statsPeriod when relative === defaultStatsPeriod?.statsPeriod without checking shouldShowSinceFirstSeenOption. When this config is false, defaultStatsPeriod.statsPeriod is always "14d", so selecting "14 days" from the dropdown incorrectly clears the URL parameter instead of setting it. The special clearing logic should only apply when shouldShowSinceFirstSeenOption is true.

Fix in Cursor Fix in Web

shouldShowSinceFirstSeenOption
? t('Since First Seen')
: undefined,
style: {
Expand Down
Loading