feat(settings): Disable AI settings when gen-ai-features flag is off #103387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
When the organizations:gen-ai-features feature flag is disabled: - "Show Generative AI Features" toggle is disabled (grayed out) and set to off - "Enable AI Code Review" toggle is also disabled (grayed out) - Appropriate disabled reason messages are shown to users Changes: - Updated aiFeatureSettings.tsx to check feature flag and disable toggle - Updated preventAiSettings.tsx to check feature flag and show appropriate disabled reason - Added tests to verify behavior when feature flag is disabled - Updated existing tests to include feature flag where needed
The feature flag should only control whether the setting is editable, not what value is currently displayed. The defaultValue should always reflect the organization's actual hideAiFeatures setting.
The frontend receives feature flags without the 'organizations:' prefix. Changed from 'organizations:gen-ai-features' to 'gen-ai-features'.
- When feature flag is off, toggle shows as unchecked (off) regardless of org setting - Removed 'This feature is not available' tooltip - fields just gray out silently - Disabled tag only shows for specific reasons (self-hosted, non-US region) - Feature flag acts as master switch that overrides org settings in UI
Removes the async keyword from the test function that doesn't use any await expressions, fixing the eslint @typescript-eslint/require-await error.
JoshFerge
force-pushed
the
jferg/disable-ai-settings-when-feature-flag-off
branch
from
066b0d5 to
2f562f0
Compare
When the gen-ai-features flag is disabled but the organization's enablePrReviewTestGeneration setting is true, the UI was incorrectly showing the checkbox as checked. This fix uses setValue to transform the initial display value to false when the feature flag is off, ensuring the UI accurately reflects that the feature is disabled. Also adds test coverage for this scenario.
… flag is off When the gen-ai-features flag is disabled, the "Show Generative AI Features" checkbox now displays as unchecked regardless of the organization's stored hideAiFeatures value. This provides a clearer UX indicating that AI features are not available. Changes: - Added setValue to hideAiFeatures field to force display value to false when flag is off - Updated preventAiSettings visibility logic to check initialData when flag is off to prevent setValue transformation from hiding the field - When flag is on, visibility uses current model value for dynamic toggling
…sabled When the gen-ai-features flag is disabled, force the "Show Generative AI Features" checkbox to display as unchecked, even if the organization's hideAiFeatures value in the database is true. This ensures the UI accurately reflects that AI features are disabled when the feature flag is off, preventing confusion where the toggle appears enabled but is actually disabled. Implementation uses setValue to transform the initial display value to false when the feature flag is off, while keeping the API submission logic unchanged via getValue.
Comment on lines
+33
to
+38
| setValue: value => { | ||
| if (!hasFeatureFlag) { | ||
| return false; | ||
| } | ||
| return value; | ||
| }, |
Member
There was a problem hiding this comment.
I don't think this is necessary if it's already disabled.
Member
Author
There was a problem hiding this comment.
the whole set value fn?
Member
Author
There was a problem hiding this comment.
no i think it is, otherwise the value shows as true
Member
There was a problem hiding this comment.
Then it should be done in getValue I think?
Member
Author
There was a problem hiding this comment.
hmm that doesn't seem to work?
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| return false; | ||
| } | ||
| return value; | ||
| }, |
Contributor
There was a problem hiding this comment.
Bug: setValue doesn't invert hideAiFeatures value correctly
The setValue function returns the raw value when the feature flag is enabled, but it should invert it to match the UI semantics. The field stores hideAiFeatures from the backend, but the UI displays "Show Generative AI Features" (the opposite). When hasFeatureFlag is true, setValue should return !value to invert the backend value to the UI value, just like defaultValue does with !organization.hideAiFeatures. Without this inversion, a backend value of hideAiFeatures: false (AI enabled) would incorrectly display as unchecked in the UI.
static/app/views/settings/organizationGeneralSettings/preventAiSettings.tsx
Outdated
Show resolved
Hide resolved
static/app/views/settings/organizationGeneralSettings/aiFeatureSettings.tsx
Outdated
Show resolved
Hide resolved
Dhrumil-Sentry
approved these changes
Nov 19, 2025
evanpurkhiser
approved these changes
Nov 19, 2025
static/app/views/settings/organizationGeneralSettings/aiFeatureSettings.tsx
Show resolved
Hide resolved
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
JoshFerge
deleted the
jferg/disable-ai-settings-when-feature-flag-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
organizations:gen-ai-featuresfeature flag is disabled, the "gen ai" setting is now disabled and set to "off" regardless of the org's setting value.