From aceef4a3232db0f46d7df96bfe1c167c0076957b Mon Sep 17 00:00:00 2001 From: Suejung Shin Date: Fri, 14 Nov 2025 18:27:09 -0800 Subject: [PATCH] feat(prevent): Remove seer app bullet from onboarding --- .../prevent/preventAI/onboarding.spec.tsx | 30 ++----------------- .../views/prevent/preventAI/onboarding.tsx | 23 ++------------ 2 files changed, 5 insertions(+), 48 deletions(-) diff --git a/static/app/views/prevent/preventAI/onboarding.spec.tsx b/static/app/views/prevent/preventAI/onboarding.spec.tsx index 27ce0aeac22779..fb9b56ca5ff6f3 100644 --- a/static/app/views/prevent/preventAI/onboarding.spec.tsx +++ b/static/app/views/prevent/preventAI/onboarding.spec.tsx @@ -66,7 +66,7 @@ describe('PreventAIOnboarding', () => { ).toBeInTheDocument(); }); - it('renders all three onboarding steps', () => { + it('renders both onboarding steps', () => { render(, {organization}); expect(screen.getByText('1')).toBeInTheDocument(); @@ -78,9 +78,6 @@ describe('PreventAIOnboarding', () => { expect( screen.getByRole('heading', {name: 'Setup GitHub Integration'}) ).toBeInTheDocument(); - - expect(screen.getByText('3')).toBeInTheDocument(); - expect(screen.getByRole('heading', {name: 'Setup Seer'})).toBeInTheDocument(); }); it('renders external links with correct hrefs', async () => { @@ -120,14 +117,6 @@ describe('PreventAIOnboarding', () => { {organization} ); - const seerLink = screen.getByRole('link', {name: 'Seer by Sentry GitHub App'}); - expect(seerLink).toHaveAttribute('href', 'https://github.com/apps/seer-by-sentry'); - await userEvent.click(seerLink); - expect(trackAnalytics).toHaveBeenCalledWith( - 'prevent.ai_onboarding.seer_app_link.clicked', - {organization} - ); - const learnMoreLink = screen.getByRole('link', {name: 'Learn more'}); expect(learnMoreLink).toHaveAttribute( 'href', @@ -210,11 +199,10 @@ describe('PreventAIOnboarding', () => { render(, {organization}); const stepHeadings = screen.getAllByRole('heading', {level: 3}); - expect(stepHeadings).toHaveLength(3); + expect(stepHeadings).toHaveLength(2); expect(stepHeadings[0]).toHaveTextContent('Enable AI Code Review features'); expect(stepHeadings[1]).toHaveTextContent('Setup GitHub Integration'); - expect(stepHeadings[2]).toHaveTextContent('Setup Seer'); }); describe('step descriptions', () => { @@ -251,19 +239,7 @@ describe('PreventAIOnboarding', () => { expect( screen.getByText( textWithMarkupMatcher( - 'To grant Seer access to your codebase, install the Sentry GitHub App to connect your GitHub repositories. Learn more about GitHub integration.' - ) - ) - ).toBeInTheDocument(); - }); - - it('renders step 3 description with Seer app link', () => { - render(, {organization}); - - expect( - screen.getByText( - textWithMarkupMatcher( - 'AI Code Review uses the Sentry Seer agent to power its core functionalities. Install the Seer by Sentry GitHub App within the same GitHub organization.' + 'Install the Sentry GitHub App to connect your GitHub repositories and enable AI Code Review to access your codebase. Learn more about GitHub integration.' ) ) ).toBeInTheDocument(); diff --git a/static/app/views/prevent/preventAI/onboarding.tsx b/static/app/views/prevent/preventAI/onboarding.tsx index 148c03a36338ce..71dca603623b6e 100644 --- a/static/app/views/prevent/preventAI/onboarding.tsx +++ b/static/app/views/prevent/preventAI/onboarding.tsx @@ -26,7 +26,7 @@ function OnboardingStep({step, title, description}: OnboardingStepProps) { return ( {step} - + {title} @@ -205,7 +205,7 @@ export default function PreventAIOnboarding() { step={2} title={t(`Setup GitHub Integration`)} description={tct( - 'To grant Seer access to your codebase, install the [sentryGitHubApp:Sentry GitHub App] to connect your GitHub repositories. Learn more about [gitHubIntegration:GitHub integration].', + 'Install the [sentryGitHubApp:Sentry GitHub App] to connect your GitHub repositories and enable AI Code Review to access your codebase. Learn more about [gitHubIntegration:GitHub integration].', { sentryGitHubApp: ( - { - trackAnalytics('prevent.ai_onboarding.seer_app_link.clicked', { - organization, - }); - }} - /> - ), - } - )} - />