feat(explorer): highlight nav links and smooth scroll #103432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103432 +/- ##
===========================================
- Coverage 80.78% 80.67% -0.11%
===========================================
Files 9248 9243 -5
Lines 397172 394834 -2338
Branches 25158 25153 -5
===========================================
- Hits 320841 318524 -2317
+ Misses 75884 75863 -21
Partials 447 447 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| onDeleteFromIndex?: (index: number) => void; | ||
| onKeyPress?: (blockIndex: number, key: 'Enter' | 'ArrowUp' | 'ArrowDown') => boolean; | ||
| onNavigate?: () => void; | ||
| scrollContainerRef?: React.RefObject<HTMLDivElement | null>; |
Contributor
There was a problem hiding this comment.
Bug: Unused Parameter: Interface Disconnect
The scrollContainerRef parameter is added to the interface but never destructured from props or used in the function body. This means the parameter passed from explorerPanel.tsx is silently ignored, which may have been intended for some scroll-related functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights the corresponding tool call when the nav button is selected so it's more clear which button belongs to what. Also adds a link icon so you can see that nav is available even before hovering/focusing the block.
Also makes scrolling with arrow keys less jittery with proper smooth scroll
Also restyle to use more core components
(sorry for tacking on)