chore(preprod): abstract metric cards for build comparison #103469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
mtopo27
changed the title
rbro112
reviewed
Nov 17, 2025
| ); | ||
| } | ||
|
|
||
| const IconButton = styled('button')` |
Member
There was a problem hiding this comment.
I think you can just use https://sentry.sentry.io/stories/core/button#icon-only-buttons with priority transparent
rbro112
reviewed
Nov 17, 2025
| return {variant: 'muted'}; | ||
| } | ||
|
|
||
| const DiffText = styled(Text)` |
Member
There was a problem hiding this comment.
Any reason Text doesn't work here? Seems like nothing in this is necessarily warranting a styled component.
Member
There was a problem hiding this comment.
Additionally if it's for the Flex related stuff, like gap/flex-wrap, would recommend just using <Flex>
Contributor
Author
There was a problem hiding this comment.
I just kept it like it was in the old component which used a style component, will change
rbro112
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.