Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

Updates isWebVitalsEvent from the trace view to check for web vitals issue using the occurrence type instead

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 17, 2025
@edwardgou-sentry edwardgou-sentry requested a review from a team November 17, 2025 22:17
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review November 17, 2025 22:17
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner November 17, 2025 22:17
Copy link
Member

@michellewzhang michellewzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the group type IDs a constant anywhere? could be helpful to define them as constants

@edwardgou-sentry
Copy link
Contributor Author

are the group type IDs a constant anywhere? could be helpful to define them as constants

fixed!

@edwardgou-sentry edwardgou-sentry merged commit 0b601de into master Nov 18, 2025
48 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/ref/better-web-vital-issue-check branch November 18, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants