Skip to content

ref(performance): Improve web vitals issue check using occurrence type instead #103471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

ref(performance): Improve web vitals issue check using occurrence type instead #103471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebd0c7a
check for occurrence type instead
edwardgou-sentry Nov 16, 2025
ebf311e
getIssueTypeFromOccurrenceType
edwardgou-sentry Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/components/events/interfaces/performance/eventTraceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {getEventTimestampInSeconds} from 'sentry/components/events/interfaces/ut
import {generateTraceTarget} from 'sentry/components/quickTrace/utils';
import {t} from 'sentry/locale';
import {type Event} from 'sentry/types/event';
import type {Group} from 'sentry/types/group';
import {getIssueTypeFromOccurrenceType, IssueType, type Group} from 'sentry/types/group';
import type {Organization} from 'sentry/types/organization';
import {getConfigForIssueType} from 'sentry/utils/issueTypeConfig';
import useRouteAnalyticsParams from 'sentry/utils/routeAnalytics/useRouteAnalyticsParams';
Expand Down Expand Up @@ -132,7 +132,7 @@ const IssuesTraceContainer = styled('div')`
`;

const isWebVitalsEvent = (event: Event) => {
return event.tags.some((tag: {key: string}) => tag?.key === 'web_vital');
return getIssueTypeFromOccurrenceType(event.occurrence?.type) === IssueType.WEB_VITALS; // Web Vitals group type id
};

interface EventTraceViewProps {
Expand Down
Loading